Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/certs/generate.sh: should regenerate when new service names are added #7640

Open
jsha opened this issue Jul 31, 2024 · 0 comments
Open

Comments

@jsha
Copy link
Contributor

jsha commented Jul 31, 2024

After a recent pull, I was getting errors running the integration tests because test/certs/ipki/sfe.boulder/ didn't exist. That's because sfe.boulder was recently added to the list of services, but generate.sh doesn't regenerate the certificates if the ipki directory already exists:

if ! [ -d ipki ]; then
echo "Generating ipki/..."
ipki
fi

This error will affect anyone running Boulder, any time we add services to the internal PKI. We should improve the script so it automatically adds new services; for instance we could make the script check the existence of each service name's directory, rather than ipki overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant