Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component): add Image component #50

Merged
merged 5 commits into from
Jul 11, 2022
Merged

feat(component): add Image component #50

merged 5 commits into from
Jul 11, 2022

Conversation

niloysikdar
Copy link
Member

@niloysikdar niloysikdar commented Jul 3, 2022 •
edited

This Pull Request covers:

  • New component Image
  • Stories for newly added component
  • Props for the component
type ImageStyles =
  | 'root'
  | 'table'
  | 'body'
  | 'image'
  | 'caption'
  | 'imageSection'
  | 'captionSection'
  | 'imageColumn';

export interface ImageProps extends BaseStyleProp<ImageStyles> {
  src: string;
  alt: string;
  caption?: string;
  width: CSSProperties['width'];
  height?: CSSProperties['height'];
  captionAlign?: 'left' | 'center' | 'right';
}

Resolves #42

Signed-off-by: Niloy Sikdar niloysikdar30@gmail.com

@niloysikdar
feat(component): add image component
6064288 
add new Image component to render images

resolves #42

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar
docs(storybook): image stories
dc3f639 
add stories for image component using storybook

resolves #42

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar added the GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 label Jul 3, 2022
@niloysikdar
fix(src): merge main
d9086db 
Merge main branch with the latest changes

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar
fix(component): fix Image component
f3bd9b6 
fix the Image component with new structure and props

resolves #42

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar marked this pull request as ready for review July 8, 2022 19:18
@niloysikdar
fix(component): fix Image component
203f0f9 
- Fix Image component with updated structure and props
- Fix Section and Column props
- Update stories for Image component

resolves #42

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@agentmilindu agentmilindu merged commit 739f603 into main Jul 11, 2022
@agentmilindu agentmilindu deleted the feat/42-add-component-image branch July 11, 2022 17:29
github-actions bot pushed a commit that referenced this pull request Jul 11, 2022
@semantic-release-bot
chore(release): 1.5.0 [skip ci]
becf80d 
# [1.5.0](v1.4.0...v1.5.0) (2022-07-11)

### Features

* **component:** add Image component ([#50](#50)) ([739f603](739f603)), closes [#42](#42) [#42](#42) [#42](#42) [#42](#42)
@github-actions
Copy link

🎉 This PR is included in version 1.5.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agentmilindu agentmilindu agentmilindu approved these changes

Assignees
No one assigned
Labels
GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add component: Image
2 participants
@niloysikdar @agentmilindu