Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component): Add Typography component #48

Merged
merged 4 commits into from
Jul 6, 2022
Merged

feat(component): Add Typography component #48

merged 4 commits into from
Jul 6, 2022

Conversation

niloysikdar
Copy link
Member

@niloysikdar niloysikdar commented Jul 1, 2022 •
edited

This Pull Request covers:

  • New component Typography
  • Stories for newly added component
  • Props for the component
type ButtonStyles = 'root';

export interface TypographyProps extends BaseStyleProp<ButtonStyles> {
  children: ReactNode;
  variant?:
    | 'h1'
    | 'h2'
    | 'h3'
    | 'h4'
    | 'h5'
    | 'h6'
    | 'subtitle1'
    | 'subtitle2'
    | 'body1'
    | 'body2'
    | 'caption';
  align?: CSSProperties['textAlign'];
}

Resolves #41

Signed-off-by: Niloy Sikdar niloysikdar30@gmail.com

@niloysikdar
feat(component): add typography component
4f1fbad 
add new typography component to render text

resolves #41

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar
docs(storybook): typography stories
e02565c 
add stories for typography using storybook

resolves #41

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar added the GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 label Jul 1, 2022
@niloysikdar niloysikdar changed the title feat(component): add typography component feat(Component): add Typography component Jul 6, 2022
@niloysikdar niloysikdar changed the title feat(Component): add Typography component feat(component): add Typography component Jul 6, 2022
@niloysikdar niloysikdar force-pushed the feat/41-add-component-typography branch from e66f392 to 5c0af51 Compare July 6, 2022 15:32
@niloysikdar niloysikdar marked this pull request as ready for review July 6, 2022 16:23
@niloysikdar
fix(component): fix Typography component
c9626a5 
Fix Typography component with updated structure and props

resolves #41

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar force-pushed the feat/41-add-component-typography branch from ec6e6b6 to c9626a5 Compare July 6, 2022 16:37
@niloysikdar niloysikdar changed the title feat(component): add Typography component feat(component): Add Typography component Jul 6, 2022
@agentmilindu agentmilindu merged commit 3a79c83 into main Jul 6, 2022
@agentmilindu agentmilindu deleted the feat/41-add-component-typography branch July 6, 2022 16:52
github-actions bot pushed a commit that referenced this pull request Jul 6, 2022
@semantic-release-bot
chore(release): 1.4.0 [skip ci]
27dfec5 
# [1.4.0](v1.3.2...v1.4.0) (2022-07-06)

### Features

* **component:** Add Typography component ([#48](#48)) ([3a79c83](3a79c83)), closes [#41](#41)
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

🎉 This PR is included in version 1.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agentmilindu agentmilindu agentmilindu approved these changes

Assignees
No one assigned
Labels
GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add component: Typography
2 participants
@niloysikdar @agentmilindu