-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component): add button component #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloysikdar
added
the
GSoC 2022
Issues and Pull Requests under Google Summer of Code 2022
label
Jun 30, 2022
niloysikdar
force-pushed
the
feat/40-add-component-button
branch
2 times, most recently
from
July 4, 2022 07:53
6b24d6c
to
af05f67
Compare
agentmilindu
reviewed
Jul 4, 2022
fix Button component types to extend from BaseStyles and add classes to the props list fix BaseStyles to convert Record as Partial to make things optional resolves #40 Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar
force-pushed
the
feat/40-add-component-button
branch
from
July 4, 2022 16:38
af05f67
to
f0880bd
Compare
agentmilindu
reviewed
Jul 4, 2022
agentmilindu
reviewed
Jul 5, 2022
agentmilindu
reviewed
Jul 5, 2022
add new stories for Button components with Primary and Secondary variants resolves #40 Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar
force-pushed
the
feat/40-add-component-button
branch
from
July 5, 2022 08:13
ccb9735
to
309e612
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jul 5, 2022
# [1.1.0](v1.0.1...v1.1.0) (2022-07-05) ### Features * **component:** add button component ([#47](#47)) ([c846451](c846451)), closes [#40](#40) [#40](#40) [#40](#40) [#40](#40) * **component:** add column and section ([#46](#46)) ([c89ad5e](c89ad5e)), closes [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request covers:
Button
a
tag under the hoodResolves #40
Signed-off-by: Niloy Sikdar niloysikdar30@gmail.com