perf(spread/pips): use a buffer and use innerHTML only once #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2016 16:51
Before (test page): between 2 and 5 ms After (test page): less than 1ms
|
@leongersen I wonder why we need to remove css classes before emptying? To be more precise, why can't we just remove completely the scope_Target? |
vvo
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Feb 11, 2016
|
Because the slider might have user classes, as well as the classes applied by the plugin. |
|
The |
I think we should also keep the removeChild (but keep the removal of css classes, sorry I removed this without a full thinking) |
|
Yes, I'm replacing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Measured on the test page with console.time