Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh tutorial on contributing a generator #858

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

leondz
Copy link
Owner

@leondz leondz commented Aug 28, 2024

No description provided.

@leondz leondz added the documentation Improvements or additions to documentation label Aug 28, 2024
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see the added context, noted an area where we might want a digression to cover env processing special cases that were not required for the example generator.

docs/source/contributing.generator.rst Outdated Show resolved Hide resolved
docs/source/contributing.generator.rst Show resolved Hide resolved
leondz and others added 2 commits August 29, 2024 11:55
Co-authored-by: Jeffrey Martin <jemartin@nvidia.com>
Signed-off-by: Leon Derczynski <leonderczynski@gmail.com>
@leondz
Copy link
Owner Author

leondz commented Aug 29, 2024

Thanks, integrated these changes, and edited the comments & code in

@leondz leondz merged commit d327c71 into main Aug 29, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
@leondz leondz deleted the docs/generator_tutorial_config branch September 3, 2024 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants