This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
etl: do sort and file flush in another goroutine #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blxdyx
pushed a commit
to blxdyx/bsc-erigon-lib
that referenced
this pull request
Sep 13, 2023
- if provider is in-memory: do sort+flush in same goroutine - if provider is file-based: do sort+flush in another goroutine, and Load method will wait for unfinished goroutines and return error if one happened inside goroutine. Also in this case do pre-palloc of new buffer with `prevBufSize/8` size - because can't re-use prev buffer in this case. Reason: E4 has 8 etl collectors in same time (for domains/history/inverted_indices) and `sort.Stable` is kind-of bottleneck.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevBufSize/8size - because can't re-use prev buffer in this case.Reason: E4 has 8 etl collectors in same time (for domains/history/inverted_indices) and
sort.Stableis kind-of bottleneck.