fix: make sure syntax nodes always run their formatters #4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where if `ppSpace` appears in a `macro`/`elab` then it does not format with a space due to the fact that it gets wrapped as `group(ppSpace)` in the macro argument processing. Closes leanprover#4561
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 2, 2024
kmill
changed the title
group parser combinator always run its formattergroup parser combinator always run its formatter
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 2, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 2, 2024
kmill
changed the title
group parser combinator always run its formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now syntax nodes have their formatters run even if the parsers they wrap are all arity zero. This fixes an issue where if
ppSpaceappears in amacro/elabthen it does not format with a space due to the fact that macro argument processing wraps this asgroup(ppSpace), andppSpacehas arity zero.Implementation note: the fix is to make the
visitArgsformatter combinator always visit the last child, even if it does not exist (in which case the visited node will beSyntax.missing). To compensate, parser combinators like many and optional need to be sure to keep track of whether there any children. Only optional's needed to be modified.Closes #4561