Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ltsmaster] Sync druntime #3337

Closed

Conversation

Fix issue 20019: Symbol not found: _dyld_enumerate_tlv_storage on macOS 10.15
@kinke
Copy link
Member

kinke commented Feb 24, 2020

/Users/travis/build/ldc-developers/ldc/runtime/druntime/src/rt/sections_ldc.d(583): Error: @nogc function 'rt.sections_ldc.getTLSRange' cannot call non-@nogc function 'core.sys.osx.mach.dyld._dyld_image_count'
/Users/travis/build/ldc-developers/ldc/runtime/druntime/src/rt/sections_ldc.d(585): Error: @nogc function 'rt.sections_ldc.getTLSRange' cannot call non-@nogc function 'core.sys.osx.mach.dyld._dyld_get_image_header'
/Users/travis/build/ldc-developers/ldc/runtime/druntime/src/rt/sections_ldc.d(583): Error: 'core.sys.osx.mach.dyld._dyld_image_count' is not nothrow
/Users/travis/build/ldc-developers/ldc/runtime/druntime/src/rt/sections_ldc.d(585): Error: 'core.sys.osx.mach.dyld._dyld_get_image_header' is not nothrow
/Users/travis/build/ldc-developers/ldc/runtime/druntime/src/rt/sections_ldc.d(578): Error: function 'rt.sections_ldc.getTLSRange' is nothrow yet may throw

@JohanEngelen
Copy link
Member

@lionello @thewilsonator To prevent merging broken things into druntime, please always open an LDC merge request like this before merging druntime PRs such that you get CI testing. Now we get a dirty druntime commit history with fixups...

@kinke kinke changed the title Sync druntime [ltsmaster] Sync druntime Feb 24, 2020
@kinke
Copy link
Member

kinke commented Feb 24, 2020

@JohanEngelen: Do you mind a force-push on the ltsmaster druntime branch?

@kinke
Copy link
Member

kinke commented Feb 24, 2020

Attempt to fix it: #3338. Blocked because 32-bit x86 support is lacking as well.

@JohanEngelen
Copy link
Member

@JohanEngelen: Do you mind a force-push on the ltsmaster druntime branch?

Ah indeed hmm, I guess because we never referenced to it from LDC master branch, it's not too bad to do that.

@lionello
Copy link
Author

Closing because it's very stale :(

@lionello lionello closed this Nov 12, 2021
@lionello lionello deleted the fix-macos-catalina branch November 12, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants