Test merge to main

[laurenchilutti]

*add license header to missing files and fix typo in header

*updates needed for fv3_gfsphysics to have access to bounded_domain

*remove obsoleted driver/SHiELD files

*updating to fix bug where long_name and units attributes were not being captured in the RESTARTS

*remove unused function fv_diagnostics::max_vorticity_hy1

*remove avec timer remnants

*adding ability to specify prefix and directory when reading and writing restarts

*remove old style namelist read in favor of read from internal character variable

*Added option for a mean wind

*radius and omega are now re-scalable as a namelist parameter instead of using exclusively the hard-coded FMS constant.

*fv_mapz: Cleanup and added helpful annotations to avoid getting lost so easily

* remove duplicate code and fix lstatus on all grids depending on gfs_data and gfs_data.tile1

* New idealized tests

*Makes the non-hydrostatic restart variables optional for reads to allow hydrostatic ICs

*Fix the hydrostatic TE remapping; Add GMAO cubic for TE remapping, which is used if kord_tm=0 and remap_te=.true.

*Add a TE remapping option (kord_tm=0)

*Addressing GNU Warnings

*Add the L75 vertical config from HAFS

Description

Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Checklist:

Please check all whether they apply or not

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[bensonr]

In test_cases.F90, can go through and remove all of the '!!$' commented lines.

[bensonr]

Will need to go through and fix these at some point to use fms2_io.

[laurenchilutti]

Since this is the only change that would require me to re-test, I chose not to address this immediately. Would it be okay for me to put in an issue here on Github and once this is released I can work to update this?

[bensonr]

This was only a note to point out something to be addressed at a later date.

[lharris4]

Hi, Lauren. In the release notes:

radius and omega are now re-scalable as a namelist parameter instead of using exclusively the hard-coded FMS constant.

Note that "omega" is the constant, that corresponds to the planet's rotation, and not the vertical velocity in pressure coordinates. I would change this to, "The planetary radius and rotation rate are now re-scalable by a namelist parameter (small_earth_scale) instead of... "

[lharris4]

I see this in a few places. Where did this come from?

[bensonr]

That logica was brought into the development repo in Sept 2020 by Kai from github::dev/emc by Kai as part of commit 273f7afb

[lharris4]

Hi, Lauren. I think this looks good. Just a few minor things that could b edone.

Thanks for all of your work on this release.

Lucas

[lharris4]

OK, looks good. Lucas

…

On Wed, Apr 6, 2022 at 10:33 AM Rusty Benson ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In model/fv_arrays.F90 <#6 (comment)> : > !>Convenience pointers integer, pointer :: grid_number !f1p logical :: adj_mass_vmr = .false. !TER: This is to reproduce answers for verona patch. This default can be changed ! to .true. in the next city release if desired - !integer, pointer :: test_case - !real, pointer :: alpha + + logical :: w_limiter = .true. ! Fix excessive w - momentum conserving --- sjl + + ! options related to regional mode + logical :: regional = .false. !< Default setting for the regional domain. + integer :: bc_update_interval = 3 !< Default setting for interval (hours) between external regional BC data files. + integer :: nrows_blend = 0 !< # of blending rows in the outer integration domain. + logical :: write_restart_with_bcs = .false. !< Default setting for using DA-updated BC files + logical :: regional_bcs_from_gsi = .false. !< Default setting for writing restart files with boundary rows. + logical :: pass_full_omega_to_physics_in_non_hydrostatic_mode = .false. !< Default to passing local omega to physics in non-hydrostatic mode That logica was brought into the development repo in Sept 2020 by Kai from github::dev/emc by Kai as part of commit 273f7af <https://gitlab.gfdl.noaa.gov/fv3team/atmos_cubed_sphere/-/commit/273f7afb6523038a41ffbdc6c9a1e850388a15da> — Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMUQRVF4GYH73SCKONBHZ3DVDWOBXANCNFSM5SP53VBA> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[laurenchilutti]

@lharris4 @bensonr I have just made the updates you have asked for. Can you please take a look at the new RELEASE.md? If this looks good I can then create my PR to the NOAA-GFDL main branch.

[lharris4]

Hi, Lauren. Looks good to me. Thanks.