Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial implementation of hello example #1

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

keelerm84
Copy link
Member

No description provided.

Copy link

This pull request has been linked to Shortcut Story #249875: Create open feature hello app for ruby.

Gemfile Outdated
Comment on lines 5 to 6
gem 'launchdarkly-openfeature-server-sdk', path: '/home/mkeeler/code/launchdarkly/openfeature-ruby-server.git/release-please'
gem 'launchdarkly-server-sdk', path: '/home/mkeeler/code/launchdarkly/ruby-server-sdk.git/main'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change once we have released the actual OF gem.

@keelerm84 keelerm84 requested a review from a team July 16, 2024 20:10
.gitignore Outdated
Gemfile.lock
.bundle
.ruby-version
vendor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline please.

CODEOWNERS Outdated
@@ -0,0 +1,2 @@
# Repository Maintainers
* @launchdarkly/team-sdk-ruby
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline please.

@keelerm84 keelerm84 merged commit cb3c7d2 into main Aug 5, 2024
1 check passed
@keelerm84 keelerm84 deleted the mk/sc-sc-249875/implementation branch August 5, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants