Support $NNN bind parameters for sqlite #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitsky
changed the title
nitsky
changed the title
|
@nitsky I would like to at least see a test for this to make sure it works as expected. You can just go into |
abonander
requested changes
Nov 5, 2020
abonander
reviewed
Nov 6, 2020
abonander
approved these changes
Nov 6, 2020
|
Excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sqlite driver for sqlx currently supports only the
?and?NNNbind parameter formats. However, sqlite supports additional formats as specified here: https://sqlite.org/c3ref/bind_blob.html. With this change, I propose adding support for$NNN, which is a subset of$VVV. This will make it easier for sqlx users to write queries that are supported by both sqlite and postgres.