Expose pipes_as_concat in the database URL #2775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still of the same persuasion as #2135: I don't think the database URL is the right place for this setting to live, as it's less a property of a given connection and more of a property of the code that's going to be using the connection and whether it assumes pipes mean concat or not. We really need to be able to pass this configuration directly to the macros somehow. I'm not going to make any promises I can't keep, but I'd certainly like to work on a solution for this for the next release. There's some existing discussion in #121. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option to set
pipes_as_concatis currently not exposed in the MySQL database URL parsing function.Because some sqlx features like
cargo buildsupport andcargo sqlxcan only be configured through a database URL this makes it impossible to work with some databases that don't supportPIPES_AS_CONCAT.This adds the ability to set the flag through the database URL, which makes it possible to work with those databases.