Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Suggest predis instead of requiring it #531

Merged
merged 4 commits into from
Feb 28, 2019
Merged

[4.0] Suggest predis instead of requiring it #531

merged 4 commits into from
Feb 28, 2019

Commits on Feb 28, 2019

  1. Suggest predis instead of requiring it 

    Just like laravel/framework which suggests predis (and people can choose to use phpredis instead), Horizon should suggest it so people using phpredis do not needlessly install a dependency. Horizon relies on the redis config in config/database.php anyway, and trusts that the user correctly fills in that information. Requiring the user to install phpredis or predis herself is no different from what other parts of Laravel using Redis already do.
    @ThomHurks
    ThomHurks authored Feb 28, 2019
    Configuration menu
    Copy the full SHA
    157c6ff View commit details
    Browse the repository at this point in the history

  2. Fix the build, suggest phpredis. 

    - Added predis to the dev dependencies so the build works
- Also suggest ext-redis so people can choose
    @ThomHurks
    ThomHurks authored Feb 28, 2019
    Configuration menu
    Copy the full SHA
    6462648 View commit details
    Browse the repository at this point in the history

  3. Update composer.json 

    Co-Authored-By: ThomHurks <thomhurks@gmail.com>
    @driesvints @ThomHurks
    driesvints and ThomHurks authored Feb 28, 2019
    Configuration menu
    Copy the full SHA
    7121e2a View commit details
    Browse the repository at this point in the history

  4. Update composer.json

    @taylorotwell
    taylorotwell authored Feb 28, 2019
    Configuration menu
    Copy the full SHA
    286186c View commit details
    Browse the repository at this point in the history