Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Use router-link on recent jobs's failed jobs link #466

Merged
merged 1 commit into from
Jan 14, 2019
Merged

[2.0] Use router-link on recent jobs's failed jobs link #466

merged 1 commit into from
Jan 14, 2019

Conversation

eduPHP
Copy link
Contributor

@eduPHP eduPHP commented Jan 13, 2019

So, because of some limitations on my production server I had to use this horizon.uri config option and got it working after some tweaking.

This PR fixes one link that wasn't using router-link and was not working for me.

@eduPHP eduPHP changed the title Use router-link on recent jobs's failed jobs anchor tag Use router-link on recent jobs's failed jobs link Jan 13, 2019
@driesvints driesvints changed the title Use router-link on recent jobs's failed jobs link [2.0] Use router-link on recent jobs's failed jobs link Jan 14, 2019
@driesvints
Copy link
Member

We're not using this anywhere else in the library atm plus the config option was recently removed because its implementation was incomplete: de6b0ca

@eduPHP
Copy link
Contributor Author

eduPHP commented Jan 14, 2019

Are you not using router-link anywhere? I am not sure why this can't be merged

@driesvints
Copy link
Member

@swalker2 Ah sorry, seems I was mistaken. We do indeed use it.

@taylorotwell taylorotwell merged commit 1ad8910 into laravel:2.0 Jan 14, 2019
@eduPHP eduPHP deleted the fix-failed-recent-jobs-link branch January 14, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants