[5.x] Pass event instance to event listeners tag() method #1361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common problem I have is that it's hard to deal with tags on queued event listeners.
On a regular job, you have the payload available on the constructor, so you can use that as usual, e.g:
On an event listener, the event instance is passed to the
handle
method, so when Horizon calls->tags()
, we can't access any context.This PR aims to improve that by storing the event that's being handled when building tags, and passing that event instance to the tags method, so we can do something like this: