Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Allow composer require illuminate/routing without extra illuminate/events #7582

Closed
wants to merge 1 commit into from

Conversation

Marwelln
Copy link
Contributor

If we are trying to use illuminate/routing, we are required to manually require illuminate/events as it's used in the __construct method of Illuminate\Routing\Router.php. This change will allow us to only require illuminate/routing if we want to use the routing system without the main Laravel framework.

If we are trying to use `illuminate/routing`, we are required to manually require `illuminate/events` as it's used in the [`__construct`](https://github.com/laravel/framework/blob/5.0/src/Illuminate/Routing/Router.php#L110) method of  `Illuminate\Routing\Router.php`. This change will allow us to only require `illuminate/routing` if we want to use the routing system without the main Laravel framework.
@Marwelln Marwelln changed the title Update composer.json [5.0] Allow composer require illuminate/routing without extra illuminate/events Feb 23, 2015
@GrahamCampbell
Copy link
Member

Not it's not. We're asking for a contract. Please could you add this to the suggested dependencies list though, in the same format we do for the other suggestions in packages.

@crynobone
Copy link
Member

@GrahamCampbell but it would be useful if we can suggest an implementation using composer suggest.

@GrahamCampbell
Copy link
Member

@crynobone That's what I meant when I said:

Please could you add this to the suggested dependencies list though, in the same format we do for the other suggestions in packages.

@crynobone
Copy link
Member

@GrahanCampbell missed that.

@Marwelln service provider are designed to be use in Laravel. For external project you should manage configuring the service on your own, which include setting up an implementation of Illuminate\Contracts\Events\Dispatcher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants