[9.x] Use jsonb type for pgsql whereJsonLength #39619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PostgreSQL there are historically two different datatypes to store json data: The old
json
datatype storing everything as text and the newjsonb
datatype with binary storage. The old textual storage is discouraged because it is in all respects inferior to binary storage, there are very few use cases where textual storage is advantageous.Laravel uses the new jsonb datatype for all query builder operations, only
whereJsonLength
was forgotten to be adapted. Thus, any calculation of array length on jsonb columns first leads to a conversion of binary representation to textual representation. Since all other query builder operations work natively on jsonb, it is reasonable to adapt the only remaining function to fit the other query operations.