Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2.23 #26441

Closed
wants to merge 4 commits into from
Closed

4.2.23 #26441

wants to merge 4 commits into from

Conversation

web-engineer
Copy link

I've back ported a fix in 5 to solve the session fixation issue.

This is the issue discissed here -
#9251 (comment)
and fixed later in laravel 5 on commit d9e0a6a

Hoping that this helps others stuck on a 4.2 codebase experiencing the problem.

This manifests itself in the laravel logs as -

local.ERROR: 500 exception 'PDOException' with message 'SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'xxxxxxxxxx' for key 'sessions_id_unique'' in vendor/laravel/framework/src/Illuminate/Database/Connection.php:369

local.ERROR: 500 exception 'PDOException' with message 'SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'XXXXXXX' for key 'sessions_id_unique'' in vendor/laravel/framework/src/Illuminate/Database/Connection.php:369

laravel#9251 (comment)

Fix -

laravel@d9e0a6a
@web-engineer
Copy link
Author

you may want to check the composer settings, I'd not been able to test/verify the composer.json works and have managed this as a sub-repository for testing.

@driesvints
Copy link
Member

I'm sorry but we don't support 4.x any longer. You've also changed the vendor name in the composer.json which won't be merged. Furthermore this PR doesn't follows Laravel's coding style.

@driesvints driesvints closed this Nov 8, 2018
@web-engineer
Copy link
Author

As i said - i wasn't sure on the composer settings - happy to re-submit that later.

Not sure how this doesn't fit your coding "style" since the code is based on your own code from a commit on the 5.X branch.

Whilst you may not support your 4.X branch actively surely some community help to some more serious issues with this version would be of benefit to those who are not in a position to commit to upgrading to the 5.X release at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants