Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Fix sum with no results #18685

Merged
merged 1 commit into from
Apr 6, 2017
Merged

[5.1] Fix sum with no results #18685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Illuminate/Database/Query/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1690,7 +1690,9 @@ public function max($column)
*/
public function sum($column)
{
return $this->aggregate(__FUNCTION__, [$column]);
$result = $this->aggregate(__FUNCTION__, [$column]);

return $result ?: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not this:

return $this->aggregate(__FUNCTION__, [$column]) ?: 0;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just done to revert it back to its original state before the reverted code was applied. If Taylor wants, I can do it like this.

}

/**
Expand Down