[5.3] Optional starting slash for elixir asset #17359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: This is a renewal of a previous closed PR #13525 |
|
Is this perhaps a breaking change? Maybe better for 5.4? |
|
In my opinion, it's backwards compatible since the current behaviour remains unchanged and as far as I know, I don't believe there is any code out there relying on catching this exception. The change lies in the fact that the developer now avoids running into an exception when the path parameter has a leading slash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
elixir()helper function requires urls to be passed without beginning slash. Otherwise an exception will be thrown.Before this PR,
elixir('/assets/img/logo.png')would result in an exception being thrown because the starting slash is not expected. This is because of the strict match with the asset keys in the manifest and those never start with a slash.With this small addition, the starting slash will be allowed as well and gets silently accepted without error.