Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Add isRead and unread method to DatabaseNotification #17243

Merged
merged 4 commits into from
Jan 10, 2017
Merged

[5.3] Add isRead and unread method to DatabaseNotification #17243

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71e52bd
add isRead and isNotRead to DatabaseNotification
JellyBool Jan 10, 2017
1625782
change isNotRead to notRead
JellyBool Jan 10, 2017
35d9d38
finally change notRead to unread
JellyBool Jan 10, 2017
f9b10d3
Update DatabaseNotification.php
taylorotwell Jan 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/Illuminate/Notifications/DatabaseNotification.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,26 @@ public function markAsRead()
}
}

/**
* Determine a notification is read.
*
* @return bool
*/
public function isRead()
{
return $this->read_at !== null;
}

/**
* Determine a notification is not read yet.
*
* @return bool
*/
public function isNotRead()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just notRead feels better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will change that.

{
return $this->read_at === null;
}

/**
* Create a new database notification collection instance.
*
Expand Down