[5.3] Clear console application bootstrappers after each test case #17157
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Else the bootstrappers will stack up and the tests will get slower and slower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upgrade from v5.3.19 to 5.3.20 I noticed a considerable degradation of the runtime of my tests (over 50 % slower). I found that the bootstrappers array implemented in #16012 is never cleared between test cases. Instead, new bootstrappers are added for each test case, stacking them up and making the tests run slower and slower.
This PR implements clearing of the bootstrappers array after each test case. I've already asked @themsaid to have a look at this.