Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Stricter comparison when replacing URL for LocalAdapter #17097

Merged
merged 1 commit into from
Jan 3, 2017

Commits on Jan 3, 2017

  1. [5.3] Stricter comparison when replacing URL for LocalAdapter

    I have an edgy case with a directory name that starts with string `public`, like this:
    - `/storage/app/public/public.../files`
    
    So this was triggering the ternary on line `298` and the resulting URL was broken.
    Here is a real example:
    - Upload public path for LocalAdapter is `publicala/logo.svg`, full path from project root being `/storage/app/public/publicala/logo.svg`.
    - Generated URL was `https://laravelapp.dev/storageala/logo.svg`
    With this litle patch the generated URL is `https://laravelapp.dev/storage/publicala/logo.svg`
    
    This would also be useful for directory names ending with string `public`
    fgilio authored Jan 3, 2017
    Configuration menu
    Copy the full SHA
    4a23f5b View commit details
    Browse the repository at this point in the history