Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Make properties in the mailable class public #16916

Merged
merged 1 commit into from
Dec 22, 2016

Conversation

sileence
Copy link
Contributor

No description provided.

@sileence sileence force-pushed the mailable_public_properties branch 2 times, most recently from 07157a7 to 460f329 Compare December 21, 2016 23:58
@taylorotwell taylorotwell merged commit 4a5f484 into laravel:5.3 Dec 22, 2016
@GrahamCampbell
Copy link
Member

Breaking change?

@GrahamCampbell GrahamCampbell changed the title Make properties in the mailable class public [5.3] Make properties in the mailable class public Dec 22, 2016
@null9beta
Copy link

Like @GrahamCampbell mentioned this is breaking change but was introduced with a bugfix version.

It actually cost me some time of my live now, thanks to our QA that error did not make it into production but was at lease giving us some hard time on staging :)

Actually it appeared between 5.3.28 and 5.3.29.

I guess it would be great if those changes in the future would be announced with a proper version jump.

Don´t get that wrong. I love Laravel but there is some serious businesses build behind it and those rely on that fact that bugfix and minor version shall not introduce BC´s.

@sileence
Copy link
Contributor Author

@null9beta probably not the best place to talk about this, but can you tell more about the bug? Maybe there is something I can help with. You can also send me a message to sileence in Larachat.

@Jono20201
Copy link
Contributor

This was also a breaking change for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants