Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fix translator "get" method name #16778

Merged
merged 1 commit into from
Dec 13, 2016
Merged

[5.3] Fix translator "get" method name #16778

merged 1 commit into from
Dec 13, 2016

Conversation

KaneCohen
Copy link
Contributor

Laravel 5.3 updates Symfony Translation package to 3.1 version, which does not have get method name.

@GrahamCampbell GrahamCampbell changed the title Fix translator "get" method name [5.3] Fix translator "get" method name Dec 13, 2016
@vlakoff
Copy link
Contributor

vlakoff commented Dec 13, 2016

It doesn't seem to be related to a Symfony change. It seems to be a mistake in b7b049a.

Not sure trans() is the method to use either, as we are looking for an array of messages. ping @themsaid

@KaneCohen
Copy link
Contributor Author

@vlakoff trans() returns an array of items as long as given "path" has an array associated to it.

get() method simply does not exist in 3.1 Symfony Translation package.

@taylorotwell taylorotwell merged commit 5859b21 into laravel:5.3 Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants