New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] dont report exception inside signal handler #16738

Merged

taylorotwell merged 1 commit into laravel:5.3 from halaei:dont-report-in-signal-handler

Dec 10, 2016

Contributor

halaei commented Dec 10, 2016

The reasons to keep signal handler simple:

The timed-out job will be retried later and if the number of attempts exceeds, it will be reported. Therefore, reporting here is redundant.
The reporting process may get stuck forever because of network errors - for example if Bugsnag is used. I am not sure it is possible to register another signal handler inside this one to prevent the issue.


          dont report exception inside signal handler

e2965ee

taylorotwell merged commit afccec3 into laravel:5.3

GrahamCampbell changed the title ~~dont report exception inside signal handler~~ [5.3] dont report exception inside signal handler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet