New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Always preserve keys in group by #16658

Closed

sileence wants to merge 1 commit into laravel:master from sileence:preserve_keys_by_default

Contributor

sileence commented Dec 5, 2016

Following the discussion in #16644

Maybe we should always preserve the keys in this method as well?

But I'm sending this to 5.4 since this changes the behaviour of a current method.


          Remove the preserve keys option in the group by method and preserve k…

06645d5

…eys by default.

Member

taylorotwell commented Dec 5, 2016

Let's just leave this method as is for now.

taylorotwell closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet