Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Consolidate tests for first() and last() Collection methods #16532

Merged
merged 1 commit into from
Nov 24, 2016
Merged

[5.3] Consolidate tests for first() and last() Collection methods #16532

merged 1 commit into from
Nov 24, 2016

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Nov 24, 2016

Disclaimer: this one is a nitpick, but tidying the tests is not a luxury :)

Current situation, note the gap between lines 45 and 960:

Search "test(First|Last)" (8 hits)
    Line 10:     public function testFirstReturnsFirstItemInCollection()
    Line 16:     public function testLastReturnsLastItemInCollection()
    Line 23:     public function testLastWithCallback()
    Line 36:     public function testLastWithCallbackAndDefault()
    Line 45:     public function testLastWithDefaultAndWithoutCallback()
    Line 960:    public function testFirstWithCallback()
    Line 969:    public function testFirstWithCallbackAndDefault()
    Line 978:    public function testFirstWithDefaultAndWithoutCallback()

This gap was introduced in https://github.com/laravel/framework/pull/2858/files#diff-f565fa2deb7f67254a3a052a4f1d214b.

@taylorotwell taylorotwell merged commit 42767b2 into laravel:5.3 Nov 24, 2016
@vlakoff vlakoff deleted the collection-test branch November 24, 2016 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants