Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Remove integer & double from bindings when updating JSON fields #16068

Merged
merged 1 commit into from
Oct 24, 2016
Merged

[5.3] Remove integer & double from bindings when updating JSON fields #16068

merged 1 commit into from
Oct 24, 2016

Conversation

themsaid
Copy link
Member

In JsonExperssion we remove the binding palceholder and replace it with the actual value (see

), we do the same with booleans as well.

However, we only remove the bool values from the bindings array and not the integer & doubles values. This causes the bindings length to be more than the placeholders given which will lead to faulty query execution.

@taylorotwell taylorotwell merged commit 10e1e5b into laravel:5.3 Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants