Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fix Eloquent find or create/update on multiple connections #15958

Merged
merged 1 commit into from
Oct 17, 2016
Merged

[5.3] Fix Eloquent find or create/update on multiple connections #15958

merged 1 commit into from
Oct 17, 2016

Conversation

themsaid
Copy link
Member

This fix shall ensure that the search and the creation/update of instances happens on the same connection.

@taylorotwell taylorotwell merged commit 3255dd0 into laravel:5.3 Oct 17, 2016
@bergo
Copy link

bergo commented Nov 3, 2016

It seems that your fix is incorrect or not complete.
We are using an $connectionstring inside the Eloquent-Model. This will be ignored when you create an new instance with $this->query->getConnection()->getName().

When i change it to $this->model->getConnectionName() it works, but maybe its still not enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants