Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] No need to set description and shortcut twice. #15624

Merged
merged 1 commit into from
Sep 27, 2016
Merged

[5.3] No need to set description and shortcut twice. #15624

merged 1 commit into from
Sep 27, 2016

Conversation

lucasmichot
Copy link
Contributor

@lucasmichot lucasmichot commented Sep 26, 2016 •
edited
Loading

No need to set $description and $shortcut twice.

@taylorotwell taylorotwell merged commit 7a7ab8f into laravel:5.3 Sep 27, 2016
@lucasmichot lucasmichot deleted the feature/5.3/console-parser branch September 27, 2016 13:45
@tillkruss
Copy link
Contributor

I skip this in the changelog.

@phanan
Copy link
Contributor

phanan commented Sep 28, 2016 •
edited
Loading

Isn't this actually (arguably) one of the "best practices?" especially if you come from a strong-type language background? Some IDE's may even report the warning of, for instance, $description may not have been set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucasmichot @tillkruss @phanan @taylorotwell