Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Error on alias loop in container #15548

Merged
merged 1 commit into from
Sep 21, 2016
Merged

[5.1] Error on alias loop in container #15548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Illuminate/Container/Container.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,15 +1082,23 @@ protected function isBuildable($concrete, $abstract)
/**
* Get the alias for an abstract if available.
*
* @param string $abstract
* @param string $abstract
*
* @return string
* @throws \LogicException
*/
public function getAlias($abstract)
{
if (! isset($this->aliases[$abstract])) {
return $abstract;
}

if ($this->aliases[$abstract] === $abstract) {
throw new \LogicException(
"Container alias loop: {$abstract} is aliased to {$abstract}."
);
}

return $this->getAlias($this->aliases[$abstract]);
}

Expand Down