[5.3] Optimize Str::random() by just using strlen() and substr() #15104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlakoff
changed the title
|
Updated the PR by making the same change to the New figures:
18% faster. 🚀 |
|
This is a bug that was introduced by the bad PR that you referenced. Please could you send this to 5.1. :) |
|
Could you also please update the quickRandom function not use the slow mb functions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figures, for only 10,000 iterations:
So,
Str::random()is quite slow, this PR brings a speedup of about 8% which I think is worth it.The
substr()being applied on a base64 output, the change is safe and straightforward.