[5.3] Touch owners on save only if model is dirty #14214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the model
save()
method not behave correctly when saving model that is NOT dirty and the model set to touch its owners.So lets say we have posts and comments
It results with the saved model
updated_at
attribute not changing but the owner modelupdated_at
is changed.This is a suggestion for fixing this issue. In this change the
save
method will returnfalse
if the model is not dirty.