[5.3] Remove broken timestamps option #12617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The feature doesn't work so I think it's not a problem to remove it in 5.2. And if someone was extending |
|
5.3 is fine imo. |
|
@vlakoff We can still remove the feature from 5.1 and 5.2 without modifying method parameters, but I'm not sure if it's worth it. |
|
No idea why tests are failing :/ But it seems unrelated to this PR. |
|
Try rebasing your fork. |
|
The build fail due to the change of symfony class, I send a PR #12623. |
taylorotwell
added a commit
that referenced
this pull request
Mar 4, 2016
[5.3] Remove broken timestamps option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #12572 I think it's best to do it in 5.3 then.
@taylorotwell @vlakoff