[5.2] Fix each when there's no order by #11623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -295,6 +295,10 @@ public function chunk($count, callable $callback) | |||
| */ | |||
| public function each(callable $callback, $count = 1000) | |||
| { | |||
| if (is_null($this->getOrderBys())) { | |||
| $this->orderBy('id', 'asc'); | |||
There was a problem hiding this comment.
id may not always be available.
There was a problem hiding this comment.
Yeh, I know. Not sure what else we can do here.
|
Ok, I've made another change. |
| */ | ||
| public function each(callable $callback, $count = 1000) | ||
| { | ||
| if (is_null($this->getOrderBys())) { | ||
| throw new RuntimeException('You must provided an ordering on the query.'); |
There was a problem hiding this comment.
Should probably be "provide"?
There was a problem hiding this comment.
Yeh, oops. Thanks. ;)
|
@GrahamCampbell maybe they should be modified as well for 5.4? |
|
Perhaps. Feel free to send a PR for Taylor to review. Thanks. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless we add an orderby, the rows returned by chunk are undefined, the 2nd chunk could be the same as the first chunk for instance.