Throw invalid argument exception if value below zero is given

laravel · Nov 1, 2016 · 5e6de19 · 5e6de19
1 parent a9e381a
commit 5e6de19
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/Illuminate/Support/Collection.php b/src/Illuminate/Support/Collection.php
@@ -955,6 +955,12 @@ public function split($numberOfGroups)
      */
     public function chunk($size)
     {
+        if ($size < 0) {
+            throw new InvalidArgumentException(
+                'Size parameter expected to be greater than 0'
+            );
+        }
+
         if ($size == 0) {
             return new static;
         }

diff --git a/tests/Support/SupportCollectionTest.php b/tests/Support/SupportCollectionTest.php
@@ -692,6 +692,17 @@ public function testChunkWhenGivenZeroAsSize()
         );
     }
 
+    public function testChunkWhenGivenLessThanZero()
+    {
+        $collection = new Collection([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->assertEquals(
+            [],
+            $collection->chunk(-1)->toArray()
+        );
+    }
+
     public function testEvery()
     {
         $data = new Collection([