Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three more patches #165

Closed
wants to merge 49 commits into from
Closed

Three more patches #165

wants to merge 49 commits into from

Conversation

CounterPly
Copy link
Collaborator

@CounterPly CounterPly commented May 3, 2018

Patch 1:

The bench of fdb6df0 is 5643520, which is 7 nodes short.
@lantonov After giving it some thought, I am planning not to include Patch 1 in the next commit since it does not affect the bench of subsequent patches and gets reverted anyway. Feel free to change this, however.

Patch 2:

The bench of 313b074 is 5765806, which is correct. Oddly enough, this is true with or without the previous patch. This can be confirmed by excluding 59d1037 in SF as done here.

Patch 3:

The bench of 0852046 is 6361568, which is correct. This patch is also seemingly unaffected by the presence (or absence) of Patch 1.

@CounterPly CounterPly changed the title Two commits Two more patches May 3, 2018
@CounterPly CounterPly changed the title Two more patches Three more patches May 5, 2018
@CounterPly
Copy link
Collaborator Author

CounterPly commented May 5, 2018

Added a third patch [official-stockfish/Stockfish@b873086].

@lantonov @tthsqe12
Patch 2 [313b074] and Patch 3 [0852046] should be good to go.

I think it should be safe to skip Patch 1 [fdb6df0] since it (1) does not affect the benches of subsequent patches and (2) eventually gets completey reverted anyway. Any thoughts on this would be greatly appreciated.

@CounterPly
Copy link
Collaborator Author

CounterPly commented May 9, 2018

Added arm port for Patch 2.

armFishL_2018-05-09_v8
*** bench hash 16 threads 1 depth 13 ***
1: nodes: 426249 480 knps
2: nodes: 274605 538 knps
3: nodes: 84727 683 knps
4: nodes: 200489 550 knps
5: nodes: 179188 480 knps
6: nodes: 103861 469 knps
7: nodes: 231361 481 knps
8: nodes: 473551 526 knps
9: nodes: 196575 477 knps
10: nodes: 118251 509 knps
11: nodes: 188709 492 knps
12: nodes: 257362 483 knps
13: nodes: 170137 497 knps
14: nodes: 152255 480 knps
15: nodes: 181237 541 knps
16: nodes: 69072 527 knps
17: nodes: 78120 640 knps
18: nodes: 12908 586 knps
19: nodes: 66256 736 knps
20: nodes: 244076 713 knps
21: nodes: 52047 743 knps
22: nodes: 46077 921 knps
23: nodes: 120461 941 knps
24: nodes: 46074 631 knps
25: nodes: 9839 491 knps
26: nodes: 67895 634 knps
27: nodes: 182411 614 knps
28: nodes: 128263 585 knps
29: nodes: 103042 566 knps
30: nodes: 30188 656 knps
31: nodes: 60992 802 knps
32: nodes: 50779 769 knps
33: nodes: 46733 778 knps
34: nodes: 131909 701 knps
35: nodes: 206247 718 knps
36: nodes: 105384 916 knps
37: nodes: 461521 652 knps
38: nodes: 6390 456 knps
39: nodes: 17307 443 knps
40: nodes: 0 0 knps
41: nodes: 0 0 knps
42: nodes: 183258 423 knps
===========================
Total time (ms) : 10306
Nodes searched : 5765806
Nodes/second : 559461

@CounterPly
Copy link
Collaborator Author

Added arm port for Patch 3.

armFishL_2018-05-10_v8
*** bench hash 16 threads 1 depth 13 ***
1: nodes: 426246 477 knps
2: nodes: 232002 527 knps
3: nodes: 121959 655 knps
4: nodes: 221313 521 knps
5: nodes: 63740 465 knps
6: nodes: 146826 463 knps
7: nodes: 246214 455 knps
8: nodes: 560544 525 knps
9: nodes: 213287 473 knps
10: nodes: 86727 513 knps
11: nodes: 273385 480 knps
12: nodes: 241547 472 knps
13: nodes: 190611 497 knps
14: nodes: 172700 477 knps
15: nodes: 88621 527 knps
16: nodes: 50382 508 knps
17: nodes: 74174 598 knps
18: nodes: 22632 611 knps
19: nodes: 59991 697 knps
20: nodes: 341408 698 knps
21: nodes: 63050 708 knps
22: nodes: 48087 907 knps
23: nodes: 205031 953 knps
24: nodes: 58776 618 knps
25: nodes: 10315 491 knps
26: nodes: 41098 613 knps
27: nodes: 388253 590 knps
28: nodes: 279521 570 knps
29: nodes: 54207 511 knps
30: nodes: 25437 635 knps
31: nodes: 55525 804 knps
32: nodes: 82349 791 knps
33: nodes: 51246 813 knps
34: nodes: 100611 657 knps
35: nodes: 112830 671 knps
36: nodes: 144181 901 knps
37: nodes: 546889 646 knps
38: nodes: 6446 429 knps
39: nodes: 26219 476 knps
40: nodes: 0 0 knps
41: nodes: 0 0 knps
42: nodes: 227188 432 knps
===========================
Total time (ms) : 11449
Nodes searched : 6361568
Nodes/second : 555643

CounterPly and others added 20 commits May 11, 2018 07:23
A closer look at the MacOS executables revealed that they have been unusable since the switch to from fasm to fasmg in August, 2017. This patch prevents asmFishX from crashing during execution and restores its bench to be even with the latest [x86] Linux and Windows executables.

Bench: 5176807
ARM:
Newest executable only. Latest version: armFishL_2018_03_29_v8. Bench: 5149133.

make.bat:
New debug toggle to easily enable/disable errors during assembly.
Shortcuts for bmi2+popcnt processors in windows.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 5, 2018
5318575 is the official bench but 5318574 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 5, 2018
5601228 is the official bench but 5601231 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 5, 2018
5750110 is the official bench but 5750115 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
@CounterPly CounterPly mentioned this pull request Jun 5, 2018
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 5, 2018
5750110 is the official bench but 5750115 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 6, 2018
5404567 is the official bench but 5404565 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 6, 2018
5328254 is the official bench but 5328259 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 6, 2018
5741807 is the official bench but 5741805 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 6, 2018
5851102 is the official bench but 5851103 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 6, 2018
5404567 is the official bench but 5404565 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 6, 2018
5328254 is the official bench but 5328259 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 6, 2018
5741807 is the official bench but 5741805 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 6, 2018
5851102 is the official bench but 5851103 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit that referenced this pull request Jun 6, 2018
5404567 is the official bench but 5404565 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at #165 for more details.
CounterPly added a commit that referenced this pull request Jun 6, 2018
5328254 is the official bench but 5328259 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at #165 for more details.
CounterPly added a commit that referenced this pull request Jun 6, 2018
5741807 is the official bench but 5741805 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at #165 for more details.
CounterPly added a commit that referenced this pull request Jun 6, 2018
5851102 is the official bench but 5851103 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at #165 for more details.
CounterPly added a commit that referenced this pull request Jun 6, 2018
5851102 is the official bench but 5851103 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at #165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 10, 2018
5934103 is the official bench but 5934104 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit that referenced this pull request Jun 10, 2018
5934103 is the official bench but 5934104 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at #165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 28, 2018
5788691 is the official bench but 5788688 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 28, 2018
5318575 is the official bench but 5318574 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 28, 2018
5601228 is the official bench but 5601231 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 28, 2018
5750110 is the official bench but 5750115 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 28, 2018
5404567 is the official bench but 5404565 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 28, 2018
5328254 is the official bench but 5328259 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 28, 2018
5741807 is the official bench but 5741805 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 28, 2018
5851102 is the official bench but 5851103 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 28, 2018
5934103 is the official bench but 5934104 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
CounterPly added a commit to CounterPly/asmFish that referenced this pull request Jun 28, 2018
5750110 is the official bench but 5750115 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants