-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Three more patches #165
Three more patches #165
Conversation
Added a third patch [official-stockfish/Stockfish@b873086]. @lantonov @tthsqe12 I think it should be safe to skip Patch 1 [fdb6df0] since it (1) does not affect the benches of subsequent patches and (2) eventually gets completey reverted anyway. Any thoughts on this would be greatly appreciated. |
Added arm port for Patch 2. armFishL_2018-05-09_v8 |
Added arm port for Patch 3. armFishL_2018-05-10_v8 |
Original patch: official-stockfish/Stockfish@83e829c Bench: 5176807
Original patch: official-stockfish/Stockfish@d193482 Bench: 5466219
A closer look at the MacOS executables revealed that they have been unusable since the switch to from fasm to fasmg in August, 2017. This patch prevents asmFishX from crashing during execution and restores its bench to be even with the latest [x86] Linux and Windows executables. Bench: 5176807
Original patch: official-stockfish/Stockfish@196ae7c Bench: 5767699
Bench: 5149133 Original patch: official-stockfish/Stockfish@020dd69
ARM: Newest executable only. Latest version: armFishL_2018_03_29_v8. Bench: 5149133. make.bat: New debug toggle to easily enable/disable errors during assembly. Shortcuts for bmi2+popcnt processors in windows.
Bench: 5000136 Original patch: official-stockfish/Stockfish@be6fafd
Bench: 5208264 Original patch: official-stockfish/Stockfish@f6981b1
Bench: 5176807 Original patch: official-stockfish/Stockfish@83e829c
…he color. bench 5544445
5318575 is the official bench but 5318574 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5601228 is the official bench but 5601231 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5750110 is the official bench but 5750115 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5750110 is the official bench but 5750115 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5404567 is the official bench but 5404565 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5328254 is the official bench but 5328259 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5741807 is the official bench but 5741805 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5851102 is the official bench but 5851103 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5404567 is the official bench but 5404565 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5328254 is the official bench but 5328259 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5741807 is the official bench but 5741805 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5851102 is the official bench but 5851103 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5404567 is the official bench but 5404565 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at #165 for more details.
5328254 is the official bench but 5328259 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at #165 for more details.
5741807 is the official bench but 5741805 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at #165 for more details.
5851102 is the official bench but 5851103 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at #165 for more details.
5851102 is the official bench but 5851103 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at #165 for more details.
5934103 is the official bench but 5934104 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5934103 is the official bench but 5934104 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at #165 for more details.
5788691 is the official bench but 5788688 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5318575 is the official bench but 5318574 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5601228 is the official bench but 5601231 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5750110 is the official bench but 5750115 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5404567 is the official bench but 5404565 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5328254 is the official bench but 5328259 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5741807 is the official bench but 5741805 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5851102 is the official bench but 5851103 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5934103 is the official bench but 5934104 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
5750110 is the official bench but 5750115 is correct since official-stockfish/Stockfish@59d1037 was skipped in asmFish. See discussion at lantonov#165 for more details.
Patch 1:
The bench of fdb6df0 is 5643520, which is 7 nodes short.@lantonov After giving it some thought, I am planning not to include Patch 1 in the next commit since it does not affect the bench of subsequent patches and gets reverted anyway. Feel free to change this, however.
Patch 2:
The bench of 313b074 is 5765806, which is correct. Oddly enough, this is true with or without the previous patch. This can be confirmed by excluding
59d1037
in SF as done here.Patch 3:
The bench of 0852046 is 6361568, which is correct. This patch is also seemingly unaffected by the presence (or absence) of Patch 1.