-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosmosdbnosql: Added Cosmos DB NoSQL Semantic Cache Integration with tests and jupyter notebook #24424
base: master
Are you sure you want to change the base?
cosmosdbnosql: Added Cosmos DB NoSQL Semantic Cache Integration with tests and jupyter notebook #24424
Conversation
gsa9989
commented
Jul 19, 2024
- Added Cosmos DB NoSQL Semantic Cache Integration with tests and jupyter notebook
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ccurme can you please review this PR |
…a9989/langchain into users/garagundi/cosmosdbnosql
Friendly ping @ccurme for a review here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping.
See our contributing guidelines for how to format and lint code locally for future commits. I ran the formatter myself for now but there are still some type issues, would you mind taking a look? https://github.com/langchain-ai/langchain/actions/runs/10582689581/job/29323028501?pr=24424
The PR summary mentions a notebook, but I don't see any updates to documentation here. I think this would be good to add, otherwise the new cache will not be discoverable. If you edit docs/docs/integrations/llm_caching.ipynb
, it will get built into the docs preview here. Let me know if you have any questions!
libs/community/tests/integration_tests/cache/test_azure_cosmosdbnosql_cache.py
Outdated
Show resolved
Hide resolved
@ccurme Sorry, the PR fell through cracks. I have added the notebook please review. |
@ccurme Friendly ping on the status of the PR. |
Friendly ping @ccurme for a review here |
Friendly ping @isahers1 @baskaryan for a review here |
Friendly ping @ccurme @baskaryan @isahers1 for a review here. |