vertexai: fix avg log probs nan values #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkuligin
reviewed
Oct 11, 2024
| @@ -179,7 +180,10 @@ def get_generation_info( | |||
| } | |||
|
|
|||
| if hasattr(candidate, "avg_logprobs") and candidate.avg_logprobs is not None: | |||
| info["avg_logprobs"] = candidate.avg_logprobs | |||
| if isinstance(candidate.avg_logprobs, float) and not math.isnan( | |||
There was a problem hiding this comment.
we should probably check if it's >0 too
eliasecchig
force-pushed
the
fix-avg-log-probs-nan-values
branch
from
54e938d
to
7ddd834
Compare
eliasecchig
force-pushed
the
fix-avg-log-probs-nan-values
branch
from
7ddd834
to
0cccb77
Compare
lkuligin
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on https://github.com/langchain-ai/langchain-google/pull/534/files
Fixes behaviour when using astream_events and stream methods, which requires merging together metadata where some of the chunks might contain "nan" Float values.
e.g
E TypeError: Additional kwargs key avg_logprobs already exists in left dict and value has unsupported type <class 'float'>.
We introduce a generic integration test with langraph to catch this kind of errors in the future for any metadata field.