Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

officially supports python3.12 #77

Merged
merged 2 commits into from
Oct 13, 2023
Merged

officially supports python3.12 #77

merged 2 commits into from
Oct 13, 2023

Conversation

laixintao
Copy link
Collaborator

@laixintao laixintao commented Oct 7, 2023

@frostming
Copy link
Contributor

Looking into it deeper and found that the causes are multifaceted.

  1. The last version of numpy supporting 3.8 is 1.24.4, which doesn't have prebuilt wheels for Python 3.12. But the build system strictly requires setuptools==59 that doesn't work on Python 3.12. Dead end ❌ . This is possibly solvable by change the project's minimum python requires to 3.9.
  2. The pinned version of greenlet 2.0.2 doesn't have prebuilt wheels for Python 3.12, and the source files seem to be incompatible with Python 3.12. Fortunately, it can be solved by updating the version to 3.0 💡 .
  3. pandas again, no Python 3.12 wheels, and the build system requires numpy, failing due to the same reason as 1.

@laixintao
Copy link
Collaborator Author

Looking into it deeper and found that the causes are multifaceted.

  1. The last version of numpy supporting 3.8 is 1.24.4, which doesn't have prebuilt wheels for Python 3.12. But the build system strictly requires setuptools==59 that doesn't work on Python 3.12. Dead end ❌ . This is possibly solvable by change the project's minimum python requires to 3.9.
  2. The pinned version of greenlet 2.0.2 doesn't have prebuilt wheels for Python 3.12, and the source files seem to be incompatible with Python 3.12. Fortunately, it can be solved by updating the version to 3.0 💡 .
  3. pandas again, no Python 3.12 wheels, and the build system requires numpy, failing due to the same reason as 1.

Thanks so much!

I tried new verison of pandas, pdm will complain that there was a conflict, which is correct.

pdm install
Lock file hash doesn't match pyproject.toml, packages may be outdated
Updating the lock file...
🔒 Lock failed
Unable to find a resolution for numpy
because of the following conflicts:
  numpy>=1.22.4; python_version < "3.11" (from pandas@2.1.1)
  numpy>=1.23.2; python_version == "3.11" (from pandas@2.1.1)
  numpy>=1.26.0; python_version >= "3.12" (from pandas@2.1.1)
  python>=3.8 (from project)
  python>=3.9 (from pandas@2.1.0)
To fix this, you could loosen the dependency version constraints in pyproject.toml. See https://pdm.fming.dev/latest/usage/dependency/#solve-the-locking-failure for more
details.

(but pdm's message is a bit confusing, I can not tell what's the conflict about without thinkging... not a big issue though)

after all this, I realized that pandas here, only need for testing, not really a dev dependency. So I moved it out of pyproject.toml to tox, so that we can install pandas differenctly in different python version testing.

@laixintao laixintao requested a review from laike9m October 7, 2023 10:23
@laixintao laixintao changed the title running tests on python 3.12 officially supports python3.12 Oct 7, 2023
@laike9m
Copy link
Owner

laike9m commented Oct 8, 2023

Thank you both! I'll take a look when I get home

@laike9m
Copy link
Owner

laike9m commented Oct 13, 2023

So I moved it out of pyproject.toml to tox, so that we can install pandas differenctly in different python version testing.

LGTM. Thanks for making this change, and @frostming for the investigation!

@laike9m laike9m merged commit 3213fdf into master Oct 13, 2023
15 checks passed
@laike9m laike9m deleted the cov branch October 13, 2023 06:24
@laike9m
Copy link
Owner

laike9m commented Oct 13, 2023

Will create a release after adding new dunder methods to the right categories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants