Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageLayer & ObjectGroup Offset not support float value #77

Open
SunneeYang opened this issue Jun 25, 2023 · 4 comments
Open

ImageLayer & ObjectGroup Offset not support float value #77

SunneeYang opened this issue Jun 25, 2023 · 4 comments
Labels
breaking Breaking change bug

Comments

@SunneeYang
Copy link

SunneeYang commented Jun 25, 2023 •
edited
Loading

Load failed,"strconv.ParseInt: parsing "15.52": invalid syntax"
<imagelayer id="20" name="bg" opacity="0.61" offsetx="15.52" offsety="30.18"/>
@lafriks lafriks added the bug label Jul 5, 2023
@lafriks
Copy link
Owner

lafriks commented Jul 5, 2023

Looking at spec it says that offsetx and offsety are in pixels, I don't think pixels can be as float... 🤔
attels

@lafriks lafriks removed the bug label Jul 5, 2023
@distantforest1
Copy link

distantforest1 commented Oct 17, 2023 •
edited
Loading

Also getting this issue. Some engines do support subpixels, this TMX is also straight from tiled so I believe it should be supported as well.

@lafriks
Copy link
Owner

lafriks commented Oct 17, 2023

Looks like than will need to do breaking change and change to float then...

@lafriks
Copy link
Owner

lafriks commented Oct 17, 2023

PR is welcome :)

@lafriks lafriks added bug breaking Breaking change labels Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Breaking change bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lafriks @SunneeYang @distantforest1