Fix Windows file paths with embbeded FS #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npinochet
changed the title
npinochet
force-pushed
the
main
branch
2 times, most recently
from
9a4c863
to
853d73c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
File paths for
fs.FSandembed.FSare considered valid if the have forward slashes "/", this is consistent with Linux and macOS, but not Windows. To fix this, now all paths are made valid withfilepath.ToSlash, except whenos.Openis called, where it uses the native OS separator withfilepath.FromSlash. I hope this is enough to fix this issue for good.Thanks for maintaining this great project :)