Unable to bind query parameters after update

[aka-mj]

Issue Description

Unable to bind query parameters after update.

URL and query parameters:
POST 10.42.0.1:1232/api/v1/Settings/WirelessNetwork?ssid=TEST&password=pass123

Expected behaviour

After c.Bind(req) I'd expect req to hold the query parameters like it previously worked.

Actual behaviour

All fields in req are empty.

Working code to debug

type Request struct {
   SSID string `query:"ssid"`
   Pass string `query:"password"`
}

req := new(Request)
c.Bind(req)
if req.SSID == "" {
  fmt.Println("SSID empty")
}

Prints:

SSID empty

Version/commit

This broke after I updated from v4.1.17 -> v4.4.0

The fields used to be tagged json:"ssid" but looking through the docs this looks to have changed. I'm assuming I'm still missing something. Would hate to revert to the old release if I can't get this working.

[aka-mj]

I just saw the line

Query parameters (only for GET/DELETE methods)

Since I'm using a POST I guess this is no longer supported.

[aldas]

atm use as a workaround

		req := new(Request)
		if err := (&echo.DefaultBinder{}).BindQueryParams(c, req); err != nil {
			return err
		}

binding query params for POST methods was disabled because even public fields (without tags) were bound from query params. But with change "only explicit tags are bound" (v4.2.0 I think) we could allow it.

[aldas]

Note: if you used POST and c.Bind() then your req fields would/could have been overwritten by JSON payload as Echo uses default json decoder which will write to public fields even if those do not have json tag.

also there we many other problems with binding query params that way. see: #1670 #1638 #1356 #1565 #1448 #1495

[aka-mj]

Thanks @aldas, this worked. Moving forward it sounds like the recommended approach if using a POST is to put these fields in the body rather than as query parameters, is that correct?