Fix Echo.Serve() will not serve on HTTP port correctly when there is already TLSListener set to Echo instance. (#1785) #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1793 +/- ##
=======================================
Coverage 89.73% 89.73%
=======================================
Files 32 32
Lines 2669 2669
=======================================
Hits 2395 2395
Misses 175 175
Partials 99 99
Continue to review full report at Codecov.
|
…lready TLSListener set to Echo instance. (labstack#1785) This is problem when user tries to use HTTP (e.Listener) and HTTPS (e.TLSListener) with same Echo instance.
aldas
force-pushed
the
fix_issue_1785
branch
from
85a711c
to
fb03f2a
Compare
lammel
reviewed
Feb 28, 2021
_fixture/certs/README.md
Outdated
| @@ -0,0 +1,8 @@ | |||
| To Generate valid certificate and private key use following command: | |||
There was a problem hiding this comment.
Fix typo => To generate a valid certificate and private key use the following command
There was a problem hiding this comment.
fixed ... with multiple commits. please use squash when merging.
lammel
reviewed
Feb 28, 2021
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Echo.Serve() will not serve on HTTP port correctly when there is already TLSListener set to Echo instance. (#1785)
This is problem when user tries to use HTTP (e.Listener) and HTTPS (e.TLSListener) with same Echo instance. In this situation StartTLS could have already set
TLSListeneron echo instance and nowStartcall will useTLSListenerinstance on its own server instance - which is wrong.Introduced with #1735 and affects only latest v4.2.0 version