-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Echo.Serve() will not serve on HTTP port correctly when there is already TLSListener set to Echo instance. (#1785) #1793
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1793 +/- ##
=======================================
Coverage 89.73% 89.73%
=======================================
Files 32 32
Lines 2669 2669
=======================================
Hits 2395 2395
Misses 175 175
Partials 99 99
Continue to review full report at Codecov.
|
…lready TLSListener set to Echo instance. (labstack#1785) This is problem when user tries to use HTTP (e.Listener) and HTTPS (e.TLSListener) with same Echo instance.
85a711c
to
fb03f2a
Compare
_fixture/certs/README.md
Outdated
@@ -0,0 +1,8 @@ | |||
To Generate valid certificate and private key use following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo => To generate a valid certificate and private key use the following command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed ... with multiple commits. please use squash when merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added test will ensure both TLS and non-TLS work.
Approved! Thanks @aldas
Fix Echo.Serve() will not serve on HTTP port correctly when there is already TLSListener set to Echo instance. (#1785)
This is problem when user tries to use HTTP (e.Listener) and HTTPS (e.TLSListener) with same Echo instance. In this situation StartTLS could have already set
TLSListener
on echo instance and nowStart
call will useTLSListener
instance on its own server instance - which is wrong.Introduced with #1735 and affects only latest v4.2.0 version