Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid context canceled errors #1789

Merged
merged 2 commits into from
Mar 7, 2021
Merged

Conversation

clwluvw
Copy link
Contributor

@clwluvw clwluvw commented Feb 23, 2021

Return 499 Client Closed Request when the client has closed the request before the server could send a response

Signed-off-by: Seena Fallah seenafallah@gmail.com

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1789 (01fbe2a) into master (664cf8c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1789      +/-   ##
==========================================
+ Coverage   89.60%   89.63%   +0.02%     
==========================================
  Files          32       32              
  Lines        2656     2663       +7     
==========================================
+ Hits         2380     2387       +7     
  Misses        178      178              
  Partials       98       98              
Impacted Files Coverage Δ
middleware/proxy_1_11.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664cf8c...01fbe2a. Read the comment docs.

middleware/proxy_1_11.go Show resolved Hide resolved
@clwluvw clwluvw force-pushed the context-canceled branch 7 times, most recently from 591dc97 to f5707c8 Compare March 1, 2021 00:42
@clwluvw clwluvw requested a review from aldas March 1, 2021 00:44
middleware/proxy_1_11.go Outdated Show resolved Hide resolved
@clwluvw clwluvw force-pushed the context-canceled branch 2 times, most recently from b13f4a7 to 216ee0e Compare March 2, 2021 20:36
@clwluvw clwluvw requested a review from lammel March 2, 2021 20:39
Copy link
Contributor

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the updates.
Approved from my side. @aldas please merge, if there are no more comments from your side.

@lammel lammel added this to the v4.3 milestone Mar 6, 2021
middleware/proxy_1_11_test.go Outdated Show resolved Hide resolved
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Return 499 Client Closed Request when the client has closed the request before the server could send a response

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants