Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade ruff to 0.6.4 #2826

Merged
merged 4 commits into from
Sep 11, 2024
Merged

chore: Upgrade ruff to 0.6.4 #2826

merged 4 commits into from
Sep 11, 2024

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Sep 10, 2024 •
edited
Loading

This is a revisit of #2053.
Despite astral-sh/ruff#6591 and astral-sh/ruff#11056, let's upgrade Ruff to the latest version because:

  • Now most backports will target 24.03 and 24.09 (based on Python 3.12) only and we will move on to 25.03 (based on Python 3.13) as the main branch soon.
  • There are more new lint errors found with the latest version of Ruff.
    • e.g., The result of typing.get_origin() should be compared with a type using the is operator.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@achimnol achimnol added this to the 24.03 milestone Sep 10, 2024
@achimnol achimnol added area:infrastructure Infrastructure-related issues type:maintenance Maintenance issue. area:upstream Issues with root cause from upstream 3rd parties labels Sep 10, 2024
@achimnol achimnol self-assigned this Sep 10, 2024
@achimnol achimnol added the skip:changelog Make the action workflow to skip towncrier check label Sep 10, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 10, 2024
View reviewed changes
src/ai/backend/install/context.py Dismissed Show dismissed Hide dismissed
src/ai/backend/install/context.py Dismissed Show dismissed Hide dismissed
src/ai/backend/manager/cli/__main__.py Dismissed Show dismissed Hide dismissed
src/ai/backend/manager/cli/__main__.py Dismissed Show dismissed Hide dismissed
@achimnol achimnol added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit b72993a Sep 11, 2024
33 of 47 checks passed
@achimnol achimnol deleted the chore/upgrade-ruff-to-0.6.4 branch September 11, 2024 09:24
@github-actions GitHub Actions
Copy link

Backport to 24.03 is failed. Please backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@achimnol achimnol

Labels
area:infrastructure Infrastructure-related issues area:upstream Issues with root cause from upstream 3rd parties skip:changelog Make the action workflow to skip towncrier check type:maintenance Maintenance issue.
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.
1 participant
@achimnol