Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some files do not respect the linter #151

Open
Flowtter opened this issue Oct 5, 2022 · 1 comment
Open

Some files do not respect the linter #151

Flowtter opened this issue Oct 5, 2022 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@Flowtter
Copy link
Contributor

Flowtter commented Oct 5, 2022

Some files do not respect the current linter configuration (eslint).

Zones.update(zoneId, { $set: {
x1: startPosition.x | 0,
y1: startPosition.y | 0,
x2: endPosition.x | 0,
y2: endPosition.y | 0,
} });

The expected behavior would be:

          Zones.update(zoneId, {
            $set: {
              x1: startPosition.x | 0,
              y1: startPosition.y | 0,
              x2: endPosition.x | 0,
              y2: endPosition.y | 0,
            }
          });

I'm thinking about making a PR with all the fixes, but that might create a lot of merge conflicts in the pending pull requests.

Would you allow us to lint correctly the files we're editing in our pull request, or would you rather do one single pull request/commit to fix all the project?

Adding a GitHub action to check the linting of the code would also probably be a good idea.

@ramnes
Copy link
Collaborator

ramnes commented Oct 5, 2022

You mean eslint? FWIW I've added editorconfig-checker to the development dependencies in #128, so if we add a GitHub action (and we should!) let's not forget to check against all linters.

Also I think pre-commits hooks would be just as important as a GitHub action. :)

@ramnes ramnes added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants