You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm thinking about making a PR with all the fixes, but that might create a lot of merge conflicts in the pending pull requests.
Would you allow us to lint correctly the files we're editing in our pull request, or would you rather do one single pull request/commit to fix all the project?
Adding a GitHub action to check the linting of the code would also probably be a good idea.
The text was updated successfully, but these errors were encountered:
You mean eslint? FWIW I've added editorconfig-checker to the development dependencies in #128, so if we add a GitHub action (and we should!) let's not forget to check against all linters.
Also I think pre-commits hooks would be just as important as a GitHub action. :)
Some files do not respect the current linter configuration (eslint).
lemverse/core/client/scenes/scene-editor.js
Lines 114 to 119 in 19a80c8
The expected behavior would be:
I'm thinking about making a PR with all the fixes, but that might create a lot of merge conflicts in the pending pull requests.
Would you allow us to lint correctly the files we're editing in our pull request, or would you rather do one single pull request/commit to fix all the project?
Adding a GitHub action to check the linting of the code would also probably be a good idea.
The text was updated successfully, but these errors were encountered: